Allow parser context to be None #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just as a follow up I discovered this issue while implementing PR #898. So it is basically an issue which can occur during testing. |
Codecov Report
@@ Coverage Diff @@
## master #981 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 65 65
Lines 3904 3906 +2
=======================================
+ Hits 3780 3782 +2
Misses 124 124
Continue to review full report at Codecov.
|
Default parameter of `parser_context` was already set to `None` but would had always raised an error. DRF parser allows `parser_context` to be `None` to so brings DJA to use the same API.
sliverc
force-pushed
the
parse_context_none
branch
from
9bdbb34 to
fcbca4f
Compare
n2ygk
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Default parameter of
parser_contextwas already set toNonebut would had always raised an error when it was actuallyNone.DRF parser allows
parser_contextto beNoneso this PR makes the DJA parser fully compatible with DRF API.Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS